Question : Query syntax with inner join

Hey Experts,

I am working on developing a query from 2 tables. The first table is Collector_Targets and the relevant fields are Code, Target, StartDate and EndDate. This table holds agent targets and can change at any time. The second table is dataHistory with CollectorCode (foreign Key with Code in CollectorTargets), DateNumber, Branch and CollectComm.
What I am attempting to do is build a query which will return for me the SUM of CollectComm and the SUM of Target starting at a particular date and for a certain number of days for a particular branch. (Dates are numbered so it would start at 1421 and go for 10 days. The problem I am running into is the collector_targets must return ONLY the larger value if more than one target is listed per agent for that date range. The table should only have 1 active value at a time).

Here is the Stored Procedure I was playing around with (values are incorrect) but it will give an idea of what I am trying to get. I have disable locking on this since, even though I have plenty of memory and nobody is using the server but me I kept getting lock errors. Those can be ignored.

Thanks for the help,
Geoff

Code Snippet:

         
           
             1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:

           
           
             ALTER PROCEDURE dbo.GetTargets
	(
	@filter nvarchar(1000),
	@ReportDate int,
	@numDays int
	)
 
AS
SET LOCK_TIMEOUT -1
EXEC sp_indexoption 'DataHistory', 'disallowpagelocks', TRUE
EXEC sp_indexoption 'DataHistory', 'disallowrowlocks', TRUE
 
declare @query nvarchar(MAX)
SET @query='DECLARE @targets TABLE(Code nvarchar(30), target numeric(12,2));
INSERT INTO @targets SELECT      Code, MAX(Target)
                     FROM         Collector_Targets
                     WHERE     (EndDate IS NULL OR (EndDate > ' + CAST((@ReportDate - @numDays) AS nvarchar(20)) + ' AND EndDate<' + CAST(@ReportDate AS NVARCHAR(20)) + ' )) 
                     GROUP BY Code;'
 
 
SET @query= @query + 'SELECT SUM(target) as target, SUM(CollectComm) as Commission from 
            DataHistory INNER JOIN @targets as t ON DataHistory.CollectorCode=t.code 
            WHERE 
                DateNumber >= ' + CAST((@ReportDate - @numDays) AS nvarchar(20)) + ' AND
                DateNumber < ' + CAST(@ReportDate AS NVARCHAR(20)) + ' AND ' + @filter
                                
EXEC (@query)						
EXEC sp_indexoption 'DataHistory', 'disallowpagelocks', FALSE
EXEC sp_indexoption 'DataHistory', 'disallowrowlocks', FALSE

           
         

Open in New Window Select All

Answer : Query syntax with inner join

Reviewed the code - here's what should be a cleaned up version, with annotations (look for the SQL comments in the constructed querystring)

                       
         
           
             1:
2:
3:
4:
5:
6:
7:
8:
9:
10:
11:
12:
13:
14:
15:
16:
17:
18:
19:
20:
21:
22:
23:
24:
25:
26:
27:
28:
29:
30:
31:
32:
33:
34:
35:
36:
37:
38:

           
           
             ALTER PROCEDURE dbo.GetTargets
        (
        @filter nvarchar(1000),
        @ReportDate int,
        @numDays int
        )
 
AS
 
declare @query nvarchar(MAX) 
 
SET @query= 'SELECT SUM(target) as target, 
    SUM(CollectComm) as Commission 
FROM DataHistory 
INNER JOIN (
    Select 
        Code, 
        Max(Target) as Target   --- Added alias here
    From Collector_Targets 
    INNER JOIN (
        Select 
            Code, 
            Max(StartDate) As StartDate
        From Collector_Targets 
        Where StartDate <= ' + CAST(@ReportDate AS NVARCHAR(20)) +'
        GROUP BY Code 
        ) Src
        ON Src.Code = Collector_Targets.Code
        AND Src.StartDate = Collector_Targets.StartDate
    GROUP BY Collector_Targets.Code
    ) as t 
    ON DataHistory.CollectorCode = t.code 
--    AND DataHistory.StartDate = t.StartDate  -- I believe this AND clause is extraneous
WHERE DateNumber >= ' + CAST((@ReportDate - @numDays) AS nvarchar(20)) + '
    AND DateNumber < ' + CAST(@ReportDate AS NVARCHAR(20)) + ' 
    AND ' + @filter
                   
EXEC (@query)  

           
         

Open in New Window Select All